Skip to content

Add support for Microting.EntityFrameworkCore.MySql EF Core driver - #1730

Merged
bart-vmware merged 3 commits into
mainfrom
connectors-mysql-microting
Aug 17, 2026
Merged

Add support for Microting.EntityFrameworkCore.MySql EF Core driver#1730
bart-vmware merged 3 commits into
mainfrom
connectors-mysql-microting

Conversation

@bart-vmware

@bart-vmware bart-vmware commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Microting.EntityFrameworkCore.MySql is a new (maintained) fork of the abandoned Pomelo.EntityFrameworkCore.MySql driver. This PR adds support for using Microting in the EF Core Connector for MySQL.

At the time of writing, the latest Pomelo release targets EF Core 9, while Microting includes EF Core 10 support (and EF Core 11 support is on its way).

Fixed: Package Steeltoe.Connectors.EntityFrameworkCore still referenced the 8.* version of Microsoft.EntityFrameworkCore.Relational in its net10.0 target.
UPDATE: Reverted because this is too much of a breaking change (see conversation below).

Closes #1729.

Quality checklist

@bart-vmware
Add support for Microting.EntityFrameworkCore.MySql EF Core driver (w…
8bb536e 
…hich is a maintained fork of the abandoned Pomelo driver)
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 83.3%
Steeltoe.Common 86.4% 77%
Steeltoe.Common.Certificates 97.2% 80.2%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 80.9%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.3% 89.4%
Steeltoe.Configuration.CloudFoundry 98.4% 92.7%
Steeltoe.Configuration.ConfigServer 91.6% 86.2%
Steeltoe.Configuration.Encryption 97.6% 87.8%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.6% 82.6%
Steeltoe.Configuration.Placeholder 93.8% 82.6%
Steeltoe.Configuration.RandomValue 93.2% 83.3%
Steeltoe.Configuration.SpringBoot 98.3% 85%
Steeltoe.Connectors 94.5% 85.6%
Steeltoe.Connectors.EntityFrameworkCore 81% 65.3%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 84%
Steeltoe.Discovery.Eureka 91.6% 81.3%
Steeltoe.Discovery.HttpClients 89.9% 91.4%
Steeltoe.Logging.Abstractions 99.4% 95.6%
Steeltoe.Logging.DynamicConsole 100% 92.3%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 96% 87.1%
Steeltoe.Management.GitProperties.Build 95.1% 83.9%
Steeltoe.Management.Prometheus 95.8% 76.9%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 93.7%
Steeltoe.Security.Authentication.OpenIdConnect 87.7% 66.6%
Steeltoe.Security.Authorization.Certificate 95.6% 61.5%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware mentioned this pull request Aug 12, 2026
Merged
@bart-vmware bart-vmware added this to the 4.3.0 milestone Aug 12, 2026
@bart-vmware bart-vmware added Component/Connectors Issues related to Steeltoe connectors ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Aug 12, 2026
@bart-vmware
bart-vmware marked this pull request as ready for review August 12, 2026 15:45
@bart-vmware
bart-vmware requested a review from TimHess August 12, 2026 15:45
This was referenced Aug 12, 2026
Merged
Closed
TimHess
TimHess requested changes Aug 17, 2026
View reviewed changes
Comment thread ...s/src/EntityFrameworkCore/MySql/DynamicTypeAccess/MySqlEntityFrameworkCorePackageResolver.cs Outdated
@TimHess

TimHess commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixed: Package Steeltoe.Connectors.EntityFrameworkCore still referenced the 8.* version of Microsoft.EntityFrameworkCore.Relational in its net10.0 target.

It is standard to align Runtime and EF Core versions, so this change shouldn't be controversial, but I do wonder if it could cause some difficulty for Steeltoe consumers that aren't as strict about that alignment?

I'm a little hesitant to potentially force a major version bump for a significant dependency inside a minor Steeltoe release.

@bart-vmware @TimHess
Update src/Connectors/src/EntityFrameworkCore/MySql/DynamicTypeAccess…
83bcf4d 
…/MySqlEntityFrameworkCorePackageResolver.cs

Co-authored-by: Tim Hess <tim.hess@broadcom.com>
@bart-vmware

bart-vmware commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

Fixed: Package Steeltoe.Connectors.EntityFrameworkCore still referenced the 8.* version of Microsoft.EntityFrameworkCore.Relational in its net10.0 target.

It is standard to align Runtime and EF Core versions, so this change shouldn't be controversial, but I do wonder if it could cause some difficulty for Steeltoe consumers that aren't as strict about that alignment?

I'm a little hesitant to potentially force a major version bump for a significant dependency inside a minor Steeltoe release.

I suppose your concern is justified. An app explicitly referencing EF Core 10 with Steeltoe net10.0 today works accidentally because Steeltoe doesn't call any EF Core APIs with binary-breaking changes between EF Core 8 and 10. As long as Steeltoe stays that way, we should be safe, but it's a slippery slope.

If Steeltoe updated to EF Core 10 on net10.0, all consumers are forced to as well. This means they can no longer use Pomelo 9.x with EF Core 9 on .NET 10. Aside from that, there are functional breaking changes between EF Core 8, 9 and 10, that we would be forcing upon users.

I'll revert the break.

TimHess
TimHess approved these changes Aug 17, 2026
View reviewed changes

@TimHess TimHess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Aug 17, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bart-vmware
bart-vmware merged commit 8e0191b into main Aug 17, 2026
25 checks passed
@bart-vmware
bart-vmware deleted the connectors-mysql-microting branch August 17, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimHess TimHess TimHess approved these changes

Assignees

No one assigned

Labels

Component/Connectors Issues related to Steeltoe connectors ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Steeltoe.Connectors.EntityFrameworkCore - Add support to Microting.EntityFrameworkCore.MySql

2 participants

@bart-vmware @TimHess